Repository navigation
fix: allow proven-empty projectless installations to be idle - #299
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fix the demonstrated fresh, projectless installation readiness failure without creating a project or weakening Mission execution authority. Same LANE_3 writer/session; R57 branch/PR298/history/budgets preserved, no concurrent source work.
After the existing instance-owned provider check, prove the narrow empty-work condition under the canonical mutation lease using one validated read-only snapshot. Mission/allocation/intake/projection/submission/workset/planning/dispatcher/bootstrap/hostbinding/exchange-audit history retains the existing strict execution-runtime composition. Missing, corrupt, uncertain or fenced storage fails closed. No broad PeerConfigurationError fallback. Existing project/EP/provider/authority behavior remains unchanged for nonempty runtimes.
Canonical PATCH2.22.0→2.22.1, schema46 unchanged. The existing pending R57 MINOR2.23.0 remains branch-bound, not released here. Official release scope expressly authorized by Peter; no installer source, VM, helper, login, existing instance or credentials touched.
Current evidence
singlePASS: one original submission, Mission AWAITING_APPROVAL→COMPLETED with original readback/replay, no duplicate.Required delivery still open
Full current CI/coverage/TDE disposition + independent Quality/Security; normal protected exact-head implementation; own nonempty reviewed/protected Finalization; NEW exact-final-main installed HTTP/restart proof; official protected-main release workflow qualification/publication/readback/cleanup with exact version/source/wheel/sdist digests. No terminal delivery claim.
Pickup: #207 (comment)
Current review correction and actual readback
Exact head f60f418/tree0011760c6fbdced251c592e5ae90cd116843862e. Both independent complete Quality/Security SOURCE/CONTENT PASS. The first installed uncertain case shared a prior Mission and was correctly not sufficient independent evidence; original receipt retained. New proof5 uses a separately initialized uncertain-only runtime, zero Missions/one canonical dispatcher, distinct instance identity, original runtime intact. Actual fourcase installed PASS/cleanuptrue; receipt SHA2562a516145cb18bbc598e630667c573a670c3f197d9d552df6c264569ea5d7f791;346 product files source/wheel/installed exact. Product bytes unchanged after original source fix; no review waiver.
Local full original run PASS1651 tests/one existing skip/1882.517s; server_runtime789/917=86.0414%. Its in-flight module snapshot preceded final review refinements, so exact current full hosted CI39016840074 and TDE39016840030 remain mandatory. Latest hosted new installed projectless gate is already PASS; full current suite still running. Earlier CI/TDE attempts remain historical, never retagged. Automatic review rejected cancelling old runs; no cancellation retry or workaround performed.
Superseding current candidate
Reviewed head2d88b76c75d322838cd655bd6cd709181ea9fe6f/tree9ed8d84037c98fbb8228bdbc128d7821e432b061 supersedes earlier candidate statements above. Complete current source/content Quality and Security PASS. Actual current local installed projectless fourcase proof plus normal and controlled late-start race PASS, 346 payloads exact. Own uncertainty case remains separate fresh zero-Mission instance. Source regression guards17 PASS.
CI39016840074 is now original FAIL (not current PASS):1652 tests/strict server_runtime789/91786.04%/new projectless installed gate passed; existing concurrent-start aggregate gate failed. Original raw log/receipt/artifact retained without reconstructing missing individual race outcomes. Controlled actual installed RED then GREEN demonstrates an exact typed WAITING_FOR_EXECUTION→CREATED canonical refusal; only this narrow refusal additionally accepted with original one-winner/one-planner/one-submission/completion/replay requirements. Duplicate or unrelated errors still FAIL. Closed public failure diagnostics and five regression guards added. Optional controlled fixture calls original preflight and does not change normal matrix timing/criteria.
Prior TDE39016840030 workflowSUCCESS but assessmentFAIL/repositoryFAILED703OPEN65critical638high. New own qualifier.run complexity26 addressed by helper extraction (same analyzer6.0.1 now7/maxhelper8). Legacy_phase32/main64 unchanged; concurrent30→25. No TDE-PASS/suppression/waiver claimed. Product and workflow bytes unchanged by this harness follow-up.
NEW normal CI39020535589 and TDE39020535592 target exact reviewed head. New hosted projectless installed gate already PASS; complete current suite/integrations/TDE disposition and all delivery/release obligations remain OPEN. Countersgroups5/cycles13/Q5/S5 retained. Full progress: #207 (comment)
Final implementation assurance
Exact reviewed head dfc1f1d/treeaa8103bad189eb37ac9f426f02a332606e4fc166 supersedes earlier candidate statements. Both independent complete PREMERGE ASSURANCE PASS bind this source and actual complete evidence. Current required CI39023848383 SUCCESS:1659 tests1842.956s,5 existing profile skips, strict changed production coverage789/917=86.04%; all installed and preservation gates passed. Actual hosted checkout3bd04e1718d9b9ee45ff0b4e1cc2df3e57cf7814 has the identical tree and reviewed source parent.
New installed projectless4PASS artifact12097409726 ZIP178cb7a43dfa3c29f360bc65efdb8f7837fb4d0912a1efb64afc41ea4b8f7487;102 successor scenariosPASS;11 Candidate casesPASS plus expected revoked-grant negative;7 preservation casesPASS. Actual registry hashes/ZIP CRC and source/wheel/346installedpayload binding independently checked. The separate uncertain-only runtime and process restart remain explicit; simulated external owner/provider/EP boundaries are not physical installer acceptance.
Current TDE39023848386 actual1659suitePASS/2841.314s/all4capabilitiesVALID. WorkflowSUCCESS is still assessmentFAIL/repositoryFAILED/exits2/2:702OPEN65CRITICAL637HIGH. Independent Quality/Security reviewed all28 changed-path findings against source context; no concrete scoped behavior/security blocker. Own new harness complexity26 finding removed; existing debt remains OPEN without suppression/waiver/TDE-PASS. TDEartifact12097814707 ZIPb2c8be9fd85e09e643a8d65980162b3140573e9d0098bddac516cf5090329781.
Original TDE39020535592 failed before assessment from partial crash PID publication; deterministic actual writer-pause RED, atomic private pending-write/close/replace GREEN2 tests and new ordinaryinstalled Candidate11PASS close that precise fixture defect. Product/workflow/canonical predicates/deadlines unchanged. Counterscorrections6/cycles14/Q7/S7 retained; no reset. Own separate protected Finalization, NEW exact-final-main installed proof and official release remain required after implementation merge. No terminal closure or automatic successor.