Skip to content

Initial pass for he satt#1390

Open
KaushikMalapati wants to merge 8 commits intopcdshub:masterfrom
KaushikMalapati:he-satt
Open

Initial pass for he satt#1390
KaushikMalapati wants to merge 8 commits intopcdshub:masterfrom
KaushikMalapati:he-satt

Conversation

@KaushikMalapati
Copy link
Copy Markdown
Contributor

@KaushikMalapati KaushikMalapati commented Nov 17, 2025

Description

Adding new classess/screens for he solid attenuator

Motivation and Context

https://jira.slac.stanford.edu/browse/ECSENG-1523
https://jira.slac.stanford.edu/browse/ECSENG-1467

How Has This Been Tested?

Where Has This Been Documented?

image image

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@KaushikMalapati KaushikMalapati marked this pull request as ready for review March 19, 2026 01:40
@KaushikMalapati KaushikMalapati requested a review from a team as a code owner March 19, 2026 01:40
@KaushikMalapati KaushikMalapati requested review from vespos and removed request for NSLentz March 19, 2026 01:42
@vespos
Copy link
Copy Markdown
Contributor

vespos commented Mar 19, 2026

Let's update a couple things:

  • Running HE_SATT(0.001) should actually sets the transmission to the value, not just the desired setpoint
  • The output of the status is just overwhelming, let's trim it down to reporting the current transmission (both main and 3rd harmonic), the desired setpoint, the current safe_power and the state.
  • There is some weird things happening with the auto-complete:
image
  • The auto-complete should be more useful and contain access to the holders' axis for example.
image

@KaushikMalapati
Copy link
Copy Markdown
Contributor Author

@vespos can you try it again?
image

@vespos
Copy link
Copy Markdown
Contributor

vespos commented Apr 17, 2026

Tested again, functionality looks good.

Do you know what these warnings are about?

In [19]: satt(0.01)

In [20]: WARNING  set_thread at1l2_commands_reset at1l2_commands_reset: _set_and_wait(value=1, timeout=5.0, atol=None, rtol=None, kwargs={})
WARNING  set_thread at1l2_commands_request_trans at1l2_commands_request_trans: _set_and_wait(value=1, timeout=5.0, atol=None, rtol=None, kwargs={})

@ZLLentz
Copy link
Copy Markdown
Member

ZLLentz commented Apr 20, 2026

Maybe that's this timeout warning from ophyd:
https://github.com/bluesky/ophyd/blob/ed7d4bb73ef0dd870ec63228664dc727c85541cb/ophyd/signal.py#L404

I think this would happen when we put a value and then don't see the result happen in the readback for 5.0 seconds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants