Skip to content

QADC Update: Background Subtraction, CFD Edge Detection#1294

Open
slactjohnson wants to merge 3 commits intopcdshub:masterfrom
slactjohnson:qadc-ECS-5843
Open

QADC Update: Background Subtraction, CFD Edge Detection#1294
slactjohnson wants to merge 3 commits intopcdshub:masterfrom
slactjohnson:qadc-ECS-5843

Conversation

@slactjohnson
Copy link
Copy Markdown
Contributor

@slactjohnson slactjohnson commented Oct 10, 2024

Description

Adds the new PVs that have been recently added to the QADC IOC to the QADC python class. Also removes duplicate code for the qadc in the pcdsdevices codebase.

Motivation and Context

Helps support Jira ticket ECS-5843.

Closes #1190

How Has This Been Tested?

Tested interactively with a QADC running the new IOC in TMO.

Where Has This Been Documented?

This PR.

Screenshots:

Typhos screen of OUT0:
image

Control Screen:
image

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@slactjohnson
Copy link
Copy Markdown
Contributor Author

Waiting for the QADC PR to get reviewed, merged, and released prior to marking this ready for review.

@slactjohnson slactjohnson marked this pull request as ready for review October 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QADC Duplication

1 participant