Draft
Conversation
vespos
commented
Feb 28, 2024
| self._E)[0] | ||
| self.energy)[0] | ||
| z_pos = (dist - self.z_offset) * self.z_dir * 1000 | ||
| z_pos = z_pos - 100 # dirty trick to get z in the range |
Contributor
Author
There was a problem hiding this comment.
DO NOT FORGET TO REMOVE BEFORE MERGE
vespos
commented
Feb 28, 2024
| """ | ||
| if not np.isclose(pseudo_pos.beam_size, self.beam_size.position): | ||
| # if not np.isclose(pseudo_pos.beam_size, self.beam_size.position): | ||
| if True: |
Contributor
Author
There was a problem hiding this comment.
Note to self: to check again
Contributor
|
Are we looking to merge this in addition to #1194 ? It seems like there's some duplicated work here |
Contributor
Author
|
Yes, I expect #1194 to be merged first. This is sort of the next step and will likely take a bit more time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make lens stack class usable for energy scans with the CCM
Motivation and Context
This includes:
How Has This Been Tested?
Where Has This Been Documented?
Pre-merge checklist
DO NOT FORGET TO REMOVE https://github.com/pcdshub/pcdsdevices/pull/1202/files#diff-5a91e8b8e2d4fabd6201376dd1c45357ec3ccf379d64d91641b430e7cad6b84aR222 BEFORE MERGE