Fix non-constant Fprintf format strings#22
Open
HNO3Miracle wants to merge 1 commit into
Open
Conversation
Signed-off-by: HNO3Miracle <xiangao.or@isrc.iscas.ac.cn>
HNO3Miracle
force-pushed
the
fix-go-vet-nonconstant-fprintf
branch
from
June 22, 2026 07:31
3f0d06d to
cae56ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two calls where a fully assembled message is passed as the format argument to fmt.Fprintf. Recent Go vet versions report these as non-constant format strings.
The strings are already constructed by concatenation and do not use formatting directives, so fmt.Fprint is the simpler and safer call. The same fix is applied to both the root module and the v2 module.
Validation: