Skip to content

[MRG] copy dimensions from non-typecast variable config-space if available - #1

Open
Sam3077 wants to merge 1 commit into
pbalapra:masterfrom
Sam3077:first-config-fix
Open

Sam3077 wants to merge 1 commit into
pbalapra:masterfrom
Sam3077:first-config-fix

Conversation

@Sam3077

@Sam3077 Sam3077 commented Jul 30, 2020

Copy link
Copy Markdown
  • space.dimension is typecast to a Dimension object.
  • This means that the copied Optimizer would behave differently since its dimensions are no longer treated as a ConfigurationSpace.
  • This change uses the saved, original config_space variable to achieve consistent behavior.
  • If config_space is not available, just use the dimensions as previously done.

@bessex bessex left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants