Fix mock engine panic in bid gossip spec tests - #13
Merged
pawanjay176 merged 4 commits intoSep 25, 2026
Merged
pawanjay176 merged 4 commits into
pawanjay176 merged 4 commits into
Conversation
jimmygchen
marked this pull request as ready for review
September 25, 2026 04:10
pawanjay176
approved these changes
Sep 25, 2026
pawanjay176
left a comment
pawanjay176
left a comment
Owner
There was a problem hiding this comment.
Ohh nice! you could have just pushed to my branch lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mock EL panics when running the beta.2 parent-RANDAO test, even though the gossip test can pass.
all_payloads_valid()sets the response after the mock block generator runs.This uses
set_fcu_payload_statusfor the setup payload's hash so the mock returnsVALIDwithout running the generator.The vector passes on minimal and mainnet with #10061 applied.