Fix task bugs and add search filter - #42
Open
AntonKruhlou wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the CodexLab Task Tracker lab: fixes both intentional bugs and adds the search feature.
GET /tasks?status=...compared against the literal string"status"instead of the query parameter, so any status filter returned an empty list. Now compares against the actualstatusvalue.POST /tasks/{id}/completebuilt the updated task but never wrote it back to the in-memory list or calledsave_tasks, so completion never persisted. Now updates the list in place and saves it.qquery parameter onGET /tasksdoes a case-insensitive substring search acrosstitleanddescription, composable withstatus, and is a no-op when omitted.Verification
curl "/tasks?status=open"/?status=doneeach return only matching tasksPOST /tasks/3/completethenGET /tasks/3showsstatus: donewith a non-nullcompleted_atq=launch,q=report,q=LAUNCH(case-insensitive) all match expected tasksstatus=open&q=launchcombines both filters correctlydata/tasks.jsonrestored to its original committed state before this PR (no runtime test data included)