Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions app/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,18 @@ def list_tasks(status: str | None = None, q: str | None = None) -> list[dict[str
filtered: list[dict[str, Any]] = []

for task in tasks:
# Instructor note: intentional bug for the lab.
# This uses the literal string "status" instead of the query parameter value.
if status and task["status"] != "status":
# Filter by status when provided
if status and task["status"] != status:
continue

# Instructor note: partial feature for the lab.
# The route already accepts `q`, but search is not implemented yet.
# Filter by search query when provided (case-insensitive, matches title or description)
if q:
query_lower = q.lower()
title_match = query_lower in task.get("title", "").lower()
description_match = query_lower in task.get("description", "").lower()
if not (title_match or description_match):
continue

filtered.append(task)

return filtered
Expand Down Expand Up @@ -51,14 +56,11 @@ def complete_task(task_id: int) -> dict[str, Any] | None:
"""Mark a task as completed."""
tasks = load_tasks()

for task in tasks:
for i, task in enumerate(tasks):
if task["id"] == task_id:
updated_task = dict(task)
updated_task["status"] = "done"
updated_task["completed_at"] = datetime.now(timezone.utc).isoformat()

# Instructor note: intentional bug for the lab.
# The updated task is returned, but the stored list is never updated or saved.
return updated_task
task["status"] = "done"
task["completed_at"] = datetime.now(timezone.utc).isoformat()
save_tasks(tasks)
return task

return None