Skip to content

Fix task bugs and add search filter - #25

Open
Marianne-90 wants to merge 1 commit into
pavlinhristov:mainfrom
Marianne-90:codex/lab-fixes
Open

Fix task bugs and add search filter#25
Marianne-90 wants to merge 1 commit into
pavlinhristov:mainfrom
Marianne-90:codex/lab-fixes

Conversation

@Marianne-90

Copy link
Copy Markdown

Summary

  • Fix GET /tasks status filtering so it compares against the requested status.
  • Persist completed tasks before returning them.
  • Add case-insensitive q filtering across task titles and descriptions.
  • Preserve existing list behavior when q is omitted and allow q to compose with status.

Root causes

The status filter compared records with the literal string "status", and task completion returned a copied record without updating or saving the stored task list. The route already accepted q, but the service layer did not apply it.

Validation

  • Verified open and done status filtering.
  • Verified completion persistence and non-null completed_at.
  • Verified title and description search with case-insensitive queries.
  • Verified combined status and q filtering.
  • Ran service-level assertions successfully.
  • Confirmed data/tasks.json is not included in the commit.

@Marianne-90
Marianne-90 marked this pull request as ready for review July 27, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant