Fix task bugs and add search filter - #20
Open
Akram012388 wants to merge 1 commit into
Open
Conversation
Akram012388
marked this pull request as ready for review
July 16, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
GET /tasksstatus filteringqsearch across task titles and descriptionsWhy
The status filter compared records with the literal string
"status", the acceptedqparameter was not applied, and task completion returned an updated copy without saving it. These changes implement the documented API behavior and protect it with automated tests that do not modify the sample data.Python 3.9 also needs
eval-type-backportto evaluate the project's modern Pydantic annotations, so it is installed conditionally to preserve the documented Python 3.9+ support range.Verification
python -m pytest -W error -von Python 3.9: 6 passedpython -m pytest -W error -von Python 3.14: 6 passedpython -m pip checkpython -m compileall -q app testsgit diff --checkdata/tasks.jsonis unchangedCloses #2
Closes #3
Closes #4
Closes #5