Update locallib.php#4
Open
vsotirasqmplus wants to merge 1 commit into
Open
Conversation
Avoid Moodle Query duplicate records error by adding a unique id for each tuple
Collaborator
|
Could you elaborate on a situation where this update would be required? I am concerned that your code may not be portable across different database systems and the plugin should at least work with MysQL,Postgres and MS SQL Server. |
Author
|
I am sure there could be conflicts with other databases than MySQL. but the basic principle of Moodle $DB object is to retrieve tuples having their first field to be a unique identifier, which in our installation was the case, forcing Moodle to abandon records and retrieve only the ones having distinct values at the first field. So my suggestion is for MySQL, and based on identifying other databases, the principle of the $DB object query must be kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid Moodle Query duplicate records error by adding a unique id for each tuple