Restructure into a python package#56
Open
manuelmcd wants to merge 6 commits into
Open
Conversation
- Using `hatch new TabbedBoxMaker` to created package structure. - Bumps version to 1.2.0 - Add initial tests (not schroff). Using unittest since pytest does not correctly report errors in subtests
Remove the `clearance` param from schroffmaker.inx since that param was removed from the boxmaker code (667b00a)
- Fix schroff test class name - Comment out maxDiff to avoid huge diffs on fails.
Pull the piece generation code to a separate function to enable this. Move the add_args() func to a class static method to facilitate inheritance.
Not used in tabbedboxmaker
Owner
|
Thank you so much for the effort that you put into this PR. I'm sorry I never got to it. There were already some conflicts, so I've gone ahead and merged a more recent PR that I think takes this project in a good direction. Please review. Also, please see my announcement. I'm stepping back from what little I was doing for TBM. It's time for someone who is more dedicated to the project to take it over. Thanks for your understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ultimate goal being to enable use of the boxmaker code independently of Inkscape.
abstract shapes instead of SVG. (SVG generation is done by the plugin code).
v1.1, to catch bugs introduced by refactoring). Use hatch run tests to run tests.