fix/linters#36
Merged
Merged
Conversation
SabrePenguin
force-pushed
the
restore-linters
branch
from
b06f6be to
7005f53
Compare
* Added supervisord to dev container * Redirect stdout to console * Add eslint * Installed and applied pre-commit hooks * Remove .vscode from .gitignore * Turn post start into task * Move to launch.json * Remove supervisord
* python server impl of ion exchange fractionation * ion exchange fract routes * ion exchange fractionation impl * app page update to add new page * chip fixes and tooltip * filtered protein table headings * merged iex fractionation * update frontend to use new structures from backend * backend update to use more verbose structures * fixed card width issue * ticked sliders for fractions count and ph * added logarithmic scale option to chart * summary style update * refactored filtered protein detail table for better usability * Removed points from line data Co-authored-by: ldk7811 Luke Knofczynski <113363437+ldk7811@users.noreply.github.com> * removed unused icon Co-authored-by: ldk7811 Luke Knofczynski <113363437+ldk7811@users.noreply.github.com> * removed unnecessary width Co-authored-by: ldk7811 Luke Knofczynski <113363437+ldk7811@users.noreply.github.com> * Fix width issue Co-authored-by: ldk7811 Luke Knofczynski <113363437+ldk7811@users.noreply.github.com> --------- Co-authored-by: ldk7811 Luke Knofczynski <113363437+ldk7811@users.noreply.github.com>
* Lock pandas to 2.3+ * Allow debugging library code * Change to ci for package-lock
* size exclusion * fixed acceidently channge of server * fixed linting and fixed forgotten line of code * Update backend/api/size_exclusion.py Co-authored-by: ldk7811 Luke Knofczynski <113363437+ldk7811@users.noreply.github.com> * Update backend/server.py Co-authored-by: ldk7811 Luke Knofczynski <113363437+ldk7811@users.noreply.github.com> * Update backend/server.py Co-authored-by: ldk7811 Luke Knofczynski <113363437+ldk7811@users.noreply.github.com> --------- Co-authored-by: ldk7811 Luke Knofczynski <113363437+ldk7811@users.noreply.github.com>
* Stubbed dev page + konami activation. * Tyding... * I couldn't stand the horribly padded SVGs I made... * Setting up file upload for artifacts. * Artifact section done. * Added backend for artifacts. * Multi-file upload. * Adding all imports. * File preview + control disabling (PDFs need implementation). * Removed PDF packages + folderized artifacts. * File management done. * Unified scrollbar style + added PDF viewing. * Shmoley holey, completely mocked up the frontend. Need to make backend. * Formatting changes + sort of fixed SVG bug + fixed doc scroll bug. * Basic auth done. * Moved mock data to backend stub. * Added asymmetric encryption. * Added git version parsing + dev/prod app distinction. * Formatting + Added dev-health chip. * Added mutator endpoints to dash router + Tagless deploy to scripts. * Added start in case it is killed. * Changed backend restart to fire'n'forget. * It helps if you push your changes... * Switched working dir to detect backend. * Format changes + Uptime to deploy-tag + Better full-app restart. * Reverted full-app restart... * Switching rt to mb usage. * I keep forgetting to push ;( * Label changes + Removed restart delay + Added timer interval get/set. * Added polling after restart. * Reverting... * Added password cache back + upped error pct for health. * Added auto-auth + auto-refresh. * Added proper rpm + lock on rebuild. * Updated maintenance scripts to restart services on deploy + Detached checkout in backend. * Moved restart to end instead, * Fixed checkout modal lock state + fixed stale tag file bug. * Too many drinks... * Oof... * Fixed up wonky lock logic. * Fixed modal lock state x2. * Logging bc I'm losing my mind. * Debugging... * Removed deploy script debug + added Mark. * Switching to CPU. * Hopeful deploy tag bugfix. * Modal lock fix. * Making this verbose. * Dangerzone toasts. * Upped toast duration + found lock-version clobber bug. * idk man. * idk man 2x. * idk man 3x. * Removed all fallthrough logic. * Woops. * Cleaning up help. * Minor cleanuo. * Added version floor. * Updating app for script refactor. * Moved backend restart to end to fix stale state file bug. * Branch display. * Block multi-checkout. * Remove text color wipe... * Added artifact speeddial for pages.
* Correcting base version (uhg). * Stupid linter.
* changed acrylamide slider to be a dropdown * transition added * button sizing fixed * added prteolyic Digetion to 2de * starting to integrate jacobs stuff * started pde on this branch * popup UI for pd now works * integrated digestion * font color for grid changed to white * done till next wednesday * added photo * pushed env mistake and removed magic nums * loader added * Re-add basic zoom * pulled peptide retention from main * whitespace push * No changes. * No changes 2x. * final --------- Co-authored-by: jacob-fay <71296174+jacob-fay@users.noreply.github.com> Co-authored-by: Zach Van Horn <zvanhorn10@gmail.com> Co-authored-by: Luke Knofczynski <ldk7811@rit.edu>
ZythiQ
reviewed
Apr 9, 2026
Collaborator
ZythiQ
left a comment
ZythiQ
left a comment
There was a problem hiding this comment.
Would you mind adding details on why we're specifically running ShellCheck on /scripts? Also, please mention that the changes in the tests relate to your other PR, so reviewers can see the connection between the two.
Collaborator
Author
|
We run shellcheck because we want to make sure that nothing wrong is being added, and to avoid doing stuff poorly. It's basically like all the other linters. Yes, we can get away with stuff, but if something breaks, or if it's modified, then having a check that runs is extremely helpful. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the disabled linters to begin proper enforcement and requirements.