fix(book review): scroll long page and problem lists - #58
Open
patriksimms wants to merge 2 commits into
Open
Conversation
The page order and problems panels stopped at their max height and hid everything below it: the scroll viewport grew to its content height, so the card clipped the overflow and no scrollbar ever appeared. Let the viewport inherit the max height set on the scroll area root, so it becomes the scroll container. Closes #55 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> AI-Assisted-By: Codex
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> AI-Assisted-By: Codex
Owner
Author
|
CI on this branch fails at Verified this change against a green pipeline by pushing #59 + these commits on a temporary branch: the full Locally: |
patriksimms
marked this pull request as ready for review
August 18, 2026 21:31
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As an organizer reviewing a book with many responses I could not reach the pages and problems below the fold: the Page order and Problems panels stopped at their maximum height and simply cut everything off, with no scrollbar and no way to scroll.
Closes #55
Solution
The scroll area's viewport grew to its full content height, so it never became a scroll container and the surrounding card just clipped the overflow. The viewport now inherits the max height set on the scroll area root, so it scrolls as intended.
Measured on the book review page with 17 pages, viewport
clientHeight/scrollHeight:Page order
Problems
Scope
In scope: the shared scroll area wrapper, which both book review panels use.
Out of scope: changing the 620 px panel height or making the panels sticky.
Validation
format:check,lint,typecheck,testlocally; fullverifyin CI. No automated test added: the defect is a CSS constraint that only reproduces under real layout, and the demo seed has too few pages to overflow the panels, so proving it would mean reshaping the shared e2e fixture for one assertion. The measured before/after numbers above are the evidence instead.No changes outside the repository are required.
Made with Claude Opus 5 (1M context) in Claude Code.