fix(export): allow static elements beyond the bleed boundary - #57
Draft
patriksimms wants to merge 1 commit into
Draft
fix(export): allow static elements beyond the bleed boundary#57patriksimms wants to merge 1 commit into
patriksimms wants to merge 1 commit into
Conversation
Summary: - downgrade beyond-bleed problems for images and static elements to warnings - retain blocking validation for question-bound text - cover generation severity and successful preflight behavior - add matched review and export evidence Rationale: - static and image placements can be clipped by the exported page safely - organizers should still see the placement issue without losing export access Tests: - direnv exec . env SAKEKEEP_E2E_PORT=3100 bun run verify Closes #56 AI-Assisted: true AI-Agent: codex AI-Model: openai/gpt-5.6-sol
Owner
Author
Delivery statusThe change passes the complete repository gate locally:
Both required GitHub checks fail before compiling this branch because This is a baseline CI ownership failure introduced by the latest main commit, not a failure caused by this change. The PR remains draft until the required check can run successfully. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Images and other static layout elements beyond the bleed boundary currently block the organizer from exporting, even though the exported page can safely clip them.
Solution
Report those placements as warnings while preserving blocking validation for question-bound text and all unrelated export problems.
Validation
Closes #56
Built with Codex in T3 Code using gpt-5.6-sol.