Skip to content

fix(export): allow static elements beyond the bleed boundary - #57

Draft
patriksimms wants to merge 1 commit into
mainfrom
fix/nonblocking-static-bleed
Draft

fix(export): allow static elements beyond the bleed boundary#57
patriksimms wants to merge 1 commit into
mainfrom
fix/nonblocking-static-bleed

Conversation

@patriksimms

Copy link
Copy Markdown
Owner

Problem

Images and other static layout elements beyond the bleed boundary currently block the organizer from exporting, even though the exported page can safely clip them.

Solution

Report those placements as warnings while preserving blocking validation for question-bound text and all unrelated export problems.

Validation

Closes #56

Built with Codex in T3 Code using gpt-5.6-sol.

Summary:
- downgrade beyond-bleed problems for images and static elements to warnings
- retain blocking validation for question-bound text
- cover generation severity and successful preflight behavior
- add matched review and export evidence

Rationale:
- static and image placements can be clipped by the exported page safely
- organizers should still see the placement issue without losing export access

Tests:
- direnv exec . env SAKEKEEP_E2E_PORT=3100 bun run verify

Closes #56

AI-Assisted: true
AI-Agent: codex
AI-Model: openai/gpt-5.6-sol
@patriksimms

Copy link
Copy Markdown
Owner Author

Delivery status

The change passes the complete repository gate locally:

  • format, lint, and typecheck
  • 223 unit tests
  • 20 end-to-end tests (2 intentional skips)
  • production build
  • Compose and production-compose validation

Both required GitHub checks fail before compiling this branch because bun run setup:icc cannot create .local/icc after Docker creates .local as root (EACCES). The current main run fails at the same step: https://github.com/patriksimms/sakekeep/actions/runs/31974752917

This is a baseline CI ownership failure introduced by the latest main commit, not a failure caused by this change. The PR remains draft until the required check can run successfully.

@patriksimms

Copy link
Copy Markdown
Owner Author

The baseline CI fix is ready and green in #61. It upgrades actions/checkout to v7 and runs ICC setup before Docker creates .local bind-mount directories. Once #61 is merged, this PR can be updated and rerun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Images and other static elements when they go over the bleed radius should only create a warning, not an error preventing the export

1 participant