Skip to content

BLD-13: accept verified annotated tags #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick-main-promotion-bot merged 1 commit into from
Oct 14, 2026
Merged

BLD-13: accept verified annotated tags #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/scripts/verify_wheel_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,24 @@ def check_release_target(ctx, params):
except (ValueError, KeyError):
errs.append("tag ref output malformed")
else:
if obj.get("type") != "commit" or obj.get("sha") != ctx.build_sha:
if obj.get("type") == "tag":
# Annotated tag: follow it to the commit and require GitHub to
# report its signature as verified.
rc, out = ctx.run(["gh", "api", f"repos/{ctx.repo}/git/tags/{obj.get('sha')}"])
if rc != 0:
errs.append(f"cannot read annotated tag object {obj.get('sha')!r}")
else:
try:
t = json.loads(out)
target, ver = t["object"], t.get("verification") or {}
except (ValueError, KeyError):
errs.append("annotated tag object malformed")
else:
if target.get("type") != "commit" or target.get("sha") != ctx.build_sha:
errs.append(f"annotated tag {ctx.release_tag} points at {target.get('sha')!r}, not {ctx.build_sha}")
if ver.get("verified") is not True:
errs.append(f"annotated tag {ctx.release_tag} is not verified by GitHub (reason: {ver.get('reason')!r})")
elif obj.get("type") != "commit" or obj.get("sha") != ctx.build_sha:
errs.append(f"tag {ctx.release_tag} points at {obj.get('sha')!r}, not {ctx.build_sha}")
return errs

Expand Down
Loading