Skip to content

Allow asynchronous GitHub cancellation convergence - #12

Merged
patcGM merged 1 commit into
mainfrom
fix/github-cancel-reconciliation
Oct 22, 2026
Merged

patcGM merged 1 commit into
mainfrom
fix/github-cancel-reconciliation

Conversation

@patcGM

@patcGM patcGM commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Fix

  • extend GitHub read-only reconciliation to a 28-second provider convergence window
  • preserve the invariant that an accepted cancellation request is never retried
  • remain INDETERMINATE if the exact run still has not converged after the bounded window

Live evidence

The protected provider drill recorded REQUESTED once, polled the exact run, and failed closed after GitHub still reported in_progress at approximately six seconds. The provider reported the same run as cancelled moments later. npm revocation was correctly not attempted because later phases stop after an indeterminate action.

Verification

  • default-window regression assertion
  • 104 tests; 76% branch coverage
  • Ruff, format, actionlint, Bandit, and pip-audit pass

A fresh disposable GitHub run and a new preview will be used after this change reaches main.

@patcGM
patcGM requested a review from test2GM as a code owner October 22, 2026 12:15
@patcGM
patcGM merged commit be6111d into main Oct 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants