Open
Conversation
Owner
|
Thanks Jonathan! If you could rebase this now that #117's merged, that'd be great :) |
It's not supported by Trilogy
Introduces Riddle::SQLClient.connection for creating a connection using either mysql2 or trilogy. If the trilogy gem is available, it will use that by default. Tests continue to use mysql2 by default, unless overridden with, eg, `SPHINX_SQL_ADAPTER=trilogy rake`. Note that trilogy 2.11 isn't compatible with manticore, throwing a TRILOGY_TRUNCATED_PACKET error. Use 2.12+. (trilogy-libraries/trilogy#270)
Owner
|
I realise this is still marked as a draft, but FWIW the code is all looking fine to me :) |
Contributor
Author
|
Cool, thanks for checking. Before merging this I wanted to make sure it was going to work ok at the thinking-sphinx level... I'd wondered if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I wanted to add this as a stacked pull request on top of my
modernizingbranch, but maybe Github doesn't let you do that across forks..? I'll resubmit if & when #117 gets merged)This adds the groundwork for allowing Riddle/ThinkingSphinx to talk to Sphinx/Manticore using the Trilogy gem, rather than mysql2.
Before it gets merged, I want to make sure ThinkingSphinx is also going to work ok with it, but thought I should open this to check it's not going in completely the wrong direction in the meantime.