chore: Remove chain-spec-generator#296
Merged
tsenovilla merged 14 commits intomainfrom Oct 28, 2025
Merged
Conversation
Contributor
Author
|
waiting for r0gue-io/pop-cli#687 |
moliholy
reviewed
Oct 22, 2025
|
|
||
| - name: Install pop | ||
| run: | | ||
| cargo install --git https://github.com/r0gue-io/pop-cli.git --branch main |
Contributor
There was a problem hiding this comment.
what about the following?
export NONINTERACTIVE=1
curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh | bash
brew install r0gue-io/pop-cli/pop
Contributor
There was a problem hiding this comment.
It's also possible that the ubuntu host already has hombrew installed 🤔 .
Contributor
Author
There was a problem hiding this comment.
Isn't brew installing the latest release?
We'll need pop 0.11.0 for this, so til it's released we should use the main branch. After that we can use brew yep
al3mart
reviewed
Oct 22, 2025
Member
al3mart
left a comment
al3mart
left a comment
There was a problem hiding this comment.
While I agree that we are better of removing the chain-spec-generator, I'm not sure if we should do it right now.
al3mart
approved these changes
Oct 24, 2025
Member
al3mart
left a comment
al3mart
left a comment
There was a problem hiding this comment.
Happy with the current status after discussing with @tsenovilla by DMs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove chain-spec-generator and build chain specs using
pop🔗 zboto Link