fix(editor): guard door segments and columnRatios against undefined#303
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
anton-pascal
force-pushed
the
fix/sentry-EDITOR-AM
branch
from
1e3e602 to
bd789e0
Compare
anton-pascal
changed the title
…nder Legacy/unparsed door nodes can miss schema-defaulted fields (segments, columnRatios, dividerThickness, panelInset/panelDepth …) and crash the geometry build (EDITOR-AM: segments.some / seg.columnRatios.length on undefined). updateDoorMesh now re-applies the Zod defaults once at entry via DoorNodeSchema.safeParse (with a drop-bad-segments retry and a defaults fallback), so every downstream read sees populated data — including the shaped-top divider path #334 added. Also normalizes schema-valid legacy doors at load in migrateNodes, mirroring the existing stair normalizer, so the door panel and window system see defaulted data too. Reimplements #303 with the real schema defaults (the original used segments ?? [] — wrong: legacy doors rendered an empty frame — and missed the #334 dividerThickness sites). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Aymericr
force-pushed
the
fix/sentry-EDITOR-AM
branch
from
bd789e0 to
d5c9a74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sentry issue EDITOR-AM — TypeError:
Cannot read properties of undefined (reading 'length')indoor-system.tsx(487 events) AND escalating issueCannot read properties of undefined (reading 'some')(1.8k events).In
door-system.tsx, the code accessessegments.someandseg.columnRatios.lengthwithout null guards. Legacy door nodes in the database may lack these fields because they were added later to the Zod schema with a default value. When the viewer loads these nodes directly from the DB, the fields areundefined.Fix
segments ?? []for all array iterations.seg.columnRatios ?? [1](matches Zod default).seg.dividerThickness ?? 0.03(matches Zod default).