CRLF parsing micro-optimization#13
Merged
parroty merged 1 commit intoparroty:masterfrom Jan 29, 2015
Merged
Conversation
This is a tiny optimization on how CRLFs are checked (`String.ends_with?` is faster than a regex), which speeds up the stream processing process by a few percentage points. There are of course bigger fish to fry than this. E.g. it shouldn’t make a huge difference but I wanted to do a quick example of the sort of profiling/changes that should be possible now to encourage people to look for optimization opportunities. Before: #process stream - single chunk: 100000 17.98 µs/op #process stream - multi chunk: 50000 39.90 µs/op After: #process stream - single chunk: 100000 16.70 µs/op #process stream - multi chunk: 50000 35.78 µs/op
parroty
added a commit
that referenced
this pull request
Jan 29, 2015
CRLF parsing micro-optimization
Owner
|
Thanks! Your comment makes sense a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny optimization on how CRLFs are checked (
String.ends_with?is faster than a regex), which speeds up the stream processing process by a few percentage points.There are of course bigger fish to fry than this… E.g. it shouldn’t make a huge difference but I wanted to do a quick example of the sort of profiling/changes that should be possible since #11 to encourage people to look for optimization opportunities.
Before:
After: