fix: support async function tracing in trace_call and trace_function (#595)#600
Open
suhaniiz wants to merge 1 commit into
Open
fix: support async function tracing in trace_call and trace_function (#595)#600suhaniiz wants to merge 1 commit into
suhaniiz wants to merge 1 commit into
Conversation
Contributor
Author
|
hey @param20h , this pr is under gssoc 2026, lemme know if any changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
🔗 Related Issue
Closes #595
📝 What does this PR do?
This PR resolves an issue where asynchronous functions (
async def) were not being traced properly by LangSmith. Previously, running an async function inside the synchronous wrapper returned an unawaited coroutine object immediately, resulting in inaccurate tracing spans that timed the coroutine creation rather than its actual async lifecyle and execution.Changes introduced:
inspect.iscoroutinefunction(fn)to check the execution type of target functions.async_trace_callfunction path that accurately usesawaiton both the target function and the LangSmith traced function wrapper.trace_functiondecorator to dynamically provide anasync def async_wrappedexecution branch when decorating asynchronous codeblocks.🗂️ Type of Change
🧪 How was this tested?
uvicorn app.main:app --reload).📸 Screenshots (if UI change)
N/A
None. Synchronous paths remain identical and un-impacted by this change.
✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config