fix: add threading lock to LRU cache to prevent data corruption under concurrent load (#562)#583
Open
ionfwsrijan wants to merge 9 commits into
Open
fix: add threading lock to LRU cache to prevent data corruption under concurrent load (#562)#583ionfwsrijan wants to merge 9 commits into
ionfwsrijan wants to merge 9 commits into
Conversation
be32365 to
f461ad9
Compare
…parser) to account for module-level import
Contributor
Author
|
@param20h Please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The in-memory LRU cache (
_lru_get/_lru_set) uses baredictandlistwith zero synchronization. Four distinct race conditions exist:_lru_set—_lru_order.remove(key): Two threads both findkey in _lru_storeis True. Thread A callsremove(key)successfully. Thread B callsremove(key)on the already-removed key →ValueError: list.remove(x): x not in list.len(_lru_store) >= LRU_MAX_SIZE. Both pop from_lru_orderand delete from_lru_store— eviction is corrupted.if key in _lru_store, both find it absent, both append to_lru_order— duplicate entries._lru_get: While one thread is mid-json.dumps(vector), another reads partially-written JSON →json.JSONDecodeError.Changes
backend/app/cache.pyimport threading_lru_lock = threading.Lock()_lru_get,_lru_set, and_lru_deletewithwith _lru_lock:to make all LRU cache operations atomic and thread-safe.Impact
ValueErrorandjson.JSONDecodeErrorunder concurrent loadembed_texts) and user queries (embed_query)Closes #562