test: add unit tests for frontend api client wrapper#551
Open
Kishalll wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@param20h resolved conflicts pls review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #450
📝 What does this PR do?
Adds comprehensive unit tests for the frontend API client (
frontend/src/lib/api.ts).Specifically, this PR introduces
frontend/src/lib/__tests__/api.test.tswhich successfully mocksglobal.fetchandlocalStorageto thoroughly verify:- Proper formatting and injection of
AuthorizationBearer tokens.- Parameter and body serialization for both JSON requests and
FormDatapayloads (without manuallyoverriding the
Content-Typeboundary).- Error handlers correctly identifying and throwing connection errors and custom server errors.
- Automatic token refresh logic properly catching 401s and retrying the failed request with newly
provisioned tokens.
🗂️ Type of Change
🐛 Bug fix
✨ New feature
🔧 Refactor / code cleanup
📝 Documentation update
🎨 UI / styling change
⚙️ CI / tooling / config change
🧪 Tests
🧪 How was this tested?
uvicorn app.main:app --reload)npm run devinsidefrontend/)📸 Screenshots (if UI change)
N/A
No major flags! I leveraged the
jsdomVitest environment previously introduced indevto properlysimulate browser objects like
localStorageandFormDatain the testing framework.✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config