Skip to content

feat: add stop generating button#510

Open
sohika-sharma20 wants to merge 4 commits into
param20h:devfrom
sohika-sharma20:feat-stop-generating
Open

feat: add stop generating button#510
sohika-sharma20 wants to merge 4 commits into
param20h:devfrom
sohika-sharma20:feat-stop-generating

Conversation

@sohika-sharma20

Copy link
Copy Markdown

🔗 Related Issue

Closes #46

📝 What does this PR do?

Adds a Stop Generating button during streaming responses.

Changes include:

  • Replaced the loading spinner with a stop button while streaming
  • Connected the button to the existing AbortController implementation
  • Allows users to cancel active streaming responses
  • Clears the abort controller after stopping generation

🗂️ Type of Change

  • ✨ New feature
  • 🎨 UI / styling change

🧪 How was this tested?

  • Ran the frontend locally (npm run dev)
  • Verified TypeScript compilation (npx tsc --noEmit)
  • Tested streaming state behavior

⚠️ Anything to flag for reviewers?

This PR completes the UI integration for the existing AbortController-based streaming cancellation logic.

@sohika-sharma20 sohika-sharma20 requested a review from param20h as a code owner June 7, 2026 10:46
@sohika-sharma20 sohika-sharma20 deleted the feat-stop-generating branch June 7, 2026 10:52
@sohika-sharma20 sohika-sharma20 restored the feat-stop-generating branch June 7, 2026 15:44
param20h
param20h previously approved these changes Jun 7, 2026
@sohika-sharma20

Copy link
Copy Markdown
Author

@param20h Conflicts have been resolved. Could you please approve the pending workflows when you get a chance? Thanks!

param20h
param20h previously approved these changes Jun 11, 2026
@param20h

Copy link
Copy Markdown
Owner

resolve conflicts

@sohika-sharma20

Copy link
Copy Markdown
Author

resolve conflicts

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add streaming response cancellation (abort)

2 participants