Add auto Orientation option to preserve custom page dimensions#3977
Open
dsolankii wants to merge 1 commit intoparallax:masterfrom
Open
Add auto Orientation option to preserve custom page dimensions#3977dsolankii wants to merge 1 commit intoparallax:masterfrom
dsolankii wants to merge 1 commit intoparallax:masterfrom
Conversation
Author
|
Hi @HackbrettXXX @MrRio , I’ve pushed the changes for issue #3969. This PR adds the Could you please review it when you have time? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3969
What changed
autoOrientationoption tojsPDFconstructor (defaulttrue).autoOrientation: false, orientation-based dimension swapping is skipped.jsPDFOptions.autoOrientation?: boolean).Files touched
src/jspdf.jstypes/index.d.tstest/specs/jspdf.unit.spec.js