Skip to content

changed is_erc20_transfer to use Transfer signature instead of Approval#233

Open
ChadRosseau wants to merge 1 commit into
paradigmxyz:mainfrom
ChadRosseau:erc20-transfers-detection-fix
Open

changed is_erc20_transfer to use Transfer signature instead of Approval#233
ChadRosseau wants to merge 1 commit into
paradigmxyz:mainfrom
ChadRosseau:erc20-transfers-detection-fix

Conversation

@ChadRosseau

Copy link
Copy Markdown

Motivation

fixes #231

Solution

Changed erc20_transfers.rs line 104 from:

log.topics()[0] == ERC20::Approval::SIGNATURE_HASH

to

log.topics()[0] == ERC20::Transfer::SIGNATURE_HASH

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

erc20_transfers collect_by_transaction uses Approval signature instead of Transfer signature

1 participant