Conversation
Revert the scoped permissions approach in favor of --dangerously-skip-permissions for sub-agent invocations. The allowedTools whitelist was causing rate limiting issues, so switch back to the simpler skip-permissions flag. Removes DefaultAllowedTools, AllowedTools config field, --allowed-tools CLI flag, and all related plumbing through the provider system.
bdougie
changed the title
bdougie
changed the title
Emojis like ♻️ include a variation selector (U+FE0F) after the base
codepoint, which broke the \p{So} single-character match. Make the
variation selector optional with \x{FE0F}?.
Normalize struct field alignment in Config and run.go after AllowedTools removal. Remove trailing blank lines in agent tests. Pass PR title via env var instead of direct interpolation to prevent shell injection.
bdougie
added a commit
that referenced
this pull request
Mar 22, 2026
Main replaced --allowedTools with --dangerously-skip-permissions in #12. Remove all AllowedTools/DefaultAllowedTools references from config, env overrides, and tests to align with main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--allowedToolsscoped permissions system (DefaultAllowedTools,AllowedToolsconfig field,--allowed-toolsCLI flag)--dangerously-skip-permissionsinstead, reverting to the simpler approachTest plan
go test ./...— 90.2% coverage)go build ./...succeedssweeper runto verify sub-agents execute with--dangerously-skip-permissions