use sha pin (with comment) format for generated actions#23312
Merged
cburroughs merged 1 commit intopantsbuild:mainfrom May 6, 2026
Merged
use sha pin (with comment) format for generated actions#23312cburroughs merged 1 commit intopantsbuild:mainfrom
cburroughs merged 1 commit intopantsbuild:mainfrom
Conversation
cburroughs
added
the
release-notes:not-required
Per the GitHub Action best practices we recently enabled at pantsbuild#23249, we should pin each action to a SHA so that the reference is actually immutable. This will -- I hope -- knock out a large chunk of the 421 alerts we currently get from zizmor. The next followup would then be upgrades and harmonizing the generated and none-generated pins. Notice: This idea was suggested by Claude while going over pinact output and I was surprised to see that post processing the yaml wasn't too gross.
cburroughs
force-pushed
the
csb/pin-action-gen
branch
from
356d41c to
64faa88
Compare
Member
Not too sure what this means. How were the SHAs discovered? Did you use zizmor --fix or anything? |
sureshjoshi
approved these changes
May 6, 2026
Contributor
Author
I used https://github.com/suzuki-shunsuke/pinact because I didn't realize zizmor gained a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the GitHub Action best practices we recently enabled at #23249, we should pin each action to a SHA so that the reference is actually immutable.
This will -- I hope -- knock out a large chunk of the 421 alerts we currently get from zizmor. The next followup would then be upgrades and harmonizing the generated and none-generated pins.
Notice: This idea was suggested by Claude while going over pinact output and I was surprised to see that post processing the yaml wasn't too gross.