Add support for passing a dict (cam_name -> files) into fit_eks_multicam - #99
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 90.69% 90.71% +0.01%
==========================================
Files 16 16
Lines 1580 1583 +3
Branches 178 179 +1
==========================================
+ Hits 1433 1436 +3
Misses 113 113
Partials 34 34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
themattinthehatt
requested changes
Jul 16, 2026
themattinthehatt
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the PR! just a couple documentation requests
themattinthehatt
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to
fit_eks_multicamfor passing a mapping from camera name to a list of CSV files. Useful for users accessing through the API who might have naming conventions that do not fit the simple logic for detecting files per view currently used.Indirectly, it enforces that the keys of the mapping passed in match either
camera_namesor the calibration .toml (otherwise the valid files will be length 0).