Skip to content

Add support for passing a dict (cam_name -> files) into fit_eks_multicam - #99

Merged
themattinthehatt merged 3 commits into
paninski-lab:mainfrom
Hou-Lab-CSHL:main
Jul 20, 2026
Merged

Add support for passing a dict (cam_name -> files) into fit_eks_multicam#99
themattinthehatt merged 3 commits into
paninski-lab:mainfrom
Hou-Lab-CSHL:main

Conversation

@darsnack

@darsnack darsnack commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

This adds support to fit_eks_multicam for passing a mapping from camera name to a list of CSV files. Useful for users accessing through the API who might have naming conventions that do not fit the simple logic for detecting files per view currently used.

Indirectly, it enforces that the keys of the mapping passed in match either camera_names or the calibration .toml (otherwise the valid files will be length 0).

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (c1d1906) to head (ccbee91).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   90.69%   90.71%   +0.01%     
==========================================
  Files          16       16              
  Lines        1580     1583       +3     
  Branches      178      179       +1     
==========================================
+ Hits         1433     1436       +3     
  Misses        113      113              
  Partials       34       34              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@themattinthehatt themattinthehatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! just a couple documentation requests

Comment thread eks/utils.py Outdated
Comment thread eks/multicam_smoother.py
@themattinthehatt
themattinthehatt merged commit 44f4ad2 into paninski-lab:main Jul 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants