Urgent Fix for DwarfDump Pathing and Action Version Upgrades#1623
Conversation
c5acc3e to
482bbfc
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to (1) correct incorrect/duplicated source file paths emitted into DwarfDump-derived JSON by adding a root-aware path “de-stuttering” resolver, and (2) update CI/CD workflows (manual version bump input + action version upgrades, plus safer docs publishing).
Changes:
- Add
resolve_real_path()and plumb optionalproject_rootthroughparse_dwarfdump()and CLI/env handling to repair duplicated path segments. - Upgrade multiple GitHub Actions used for Docker builds/tests and add a
workflow_dispatchinput to choose version bump type. - Avoid attempting to commit/push docs when there are no documentation changes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
panda/python/core/pandare/extras/dwarfdump.py |
Adds project-root-based path repair and integrates it into DWARF parsing / CLI usage. |
.github/workflows/publish_docker.yml |
Adds manual dispatch input for bump type, upgrades actions, and skips doc push when no changes. |
.github/workflows/parallel_tests.yml |
Upgrades Docker-related actions used in CI container builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
be89173 to
0161b55
Compare
0161b55 to
aef602d
Compare
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
72cc92d to
d22915d
Compare
1f06e4a to
4a4f7df
Compare
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
4a4f7df to
5088d30
Compare
Alraedy passed linting issues flagged
5088d30 to
5480d41
Compare
…ng directories on compilation
5480d41 to
0006e80
Compare
f7d17be to
0dfd2ed
Compare
6ee2f04 to
0dfd2ed
Compare
Your checklist for this pull request
Detailed description
Currently, dwarfdump doesn't correctly generate the path if
makechanges the directory e.g., usesmake -C src, it will create duplicate entries of subdirectories as shown hereA quick fix is to add a function to check the assignment of
fnanddecl_fn, where the user provides the known root, e.g./mnt/c/Users/andre/OneDrive/Desktop/lava/target_injections/file/file-5.30and uses regex to cut any duplicates downstream for final assembly.It performs sanity checks on the hard disk to confirm that the file exists before inserting it into the JSON. See the screenshot showing the corrected files:
GitHub Actions Updates
Also, I put some important CI/CD and bumped the actions because of this warning
https://github.com/panda-re/panda/actions/runs/26796731914
As for how I updated the labeler, I used Prowler and LAVA to confirm the labels were updated correctly
https://github.com/prowler-cloud/prowler/blob/master/.github/workflows/labeler.yml
https://github.com/prowler-cloud/prowler/blob/master/.github/labeler.yml
See the updated labeler work on LAVA
panda-re/lava#98
panda-re/lava#99
...
AARCH64 had a missing entry in kernel.conf
I used the following commands within a recording to fill out the entry
Test plan
I'm manually checking my JSON files from DwarfDump to confirm they return the expected file paths.
...
Closing issues
N/A
...