Update AAarch64 VM to both run and copy_to_guest#1578
Merged
Conversation
c8cb3e9 to
b81a927
Compare
3b5292f to
cf013ee
Compare
ab2e55a to
b3cc79f
Compare
AndrewQuijano
commented
Apr 5, 2025
b3cc79f to
a0b7a46
Compare
0e16867 to
bbdeaa2
Compare
bbdeaa2 to
42bb652
Compare
42bb652 to
bb78c2f
Compare
bb78c2f to
c2b1881
Compare
c2b1881 to
3d91b90
Compare
3d91b90 to
21c415a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AArch64 PANDA VM image definitions so pandare.Panda.copy_to_guest() can insert ISO media via a configured CD-ROM device, enabling LAVA workflows that rely on copying artifacts into the guest.
Changes:
- Set the AArch64 image
cdrommonitor device name tocdrom0. - Add QEMU args to create a SCSI CD-ROM device (
virtio-scsi-pci+scsi-cd) backed by a removable-drive id=cdrom0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For LAVA to work on Aarch64, I need to copy to the guest to make hypercalls work as intended. After some testing, I added the necessary flags to the copy to make it work for the guest.
But this PR assumes that the
rootrecording isn't shot too early. See the screenshot confirming copy to the guest worked.See here as this was part of a fuller test suite.
Kernel Info for AARCH64
Also, when running the generic arch image, OSI Linux entry was missing, using these commands in a recording I obtained the necessary update for kernel.conf
To compile the kernelinfo.ko, I followed these steps to get a cross-compiled. This was done on x86-64 Ubuntu 22 VM.
I updated the LAVA script to run LAVA to have the following code to generate this output
Output
Here is the output. Some interesting things to flag. The recording failed, but I suspect the
rootsnapshot was done too early, which prompted the rescan for the copy to even work. If the snapshot is redone and the kernelinfo.conf is rebuilt, this could enable AARCH64 to fully work!bug_mining.log