Callstack_instr: disable TB chaining to improve accuracy#1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1447 switches callstack_instr to use start block exec callbacks instead of before block exec to fix an issue where tb chaining causes calls to be missed. That PR is based off a now-reverted change in #1445. Unfortunately the changes in #1447 have revealed some unexpected non-determinism around the SBE callback that we're trying to track down before merging it.
This PR acts as an interim fix for callstack_instr to improve its accuracy by ensuring tb chaining is disabled.