Skip to content

Add no_timeout and timeout options for calls#1151

Open
lacraig2 wants to merge 1 commit into
devfrom
add_timeout_record_cmd
Open

Add no_timeout and timeout options for calls#1151
lacraig2 wants to merge 1 commit into
devfrom
add_timeout_record_cmd

Conversation

@lacraig2

@lacraig2 lacraig2 commented Dec 23, 2021

Copy link
Copy Markdown
Member

This PR adds no_timeout to copy_to_guest and record_cmd as well as timeout to record_cmd.

Related to #1150

@AndrewFasano

Copy link
Copy Markdown
Contributor

Adding timeout everywhere looks good, but do we really want to have an int and a bool option for all of these? I'd think we could instead just get rid of the no_timeout flag everywhere. Either way is fine with me though

@lacraig2

lacraig2 commented Jan 6, 2022

Copy link
Copy Markdown
Member Author

@AndrewFasano That's a good point.

It looks like no_timeout only shows up in one place with run_serial_cmd. Removing it would break things currently using it.

We can certainly make these all take a timeout value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question or feature request: PyPanda API for timeout for panda.record_cmd()

2 participants