Skip to content

Add function to generate openapi spec. - #57

Open
The-Podsiadly wants to merge 1 commit into
pallets-eco:masterfrom
The-Podsiadly:feature/41/openapi-docs
Open

Add function to generate openapi spec.#57
The-Podsiadly wants to merge 1 commit into
pallets-eco:masterfrom
The-Podsiadly:feature/41/openapi-docs

Conversation

@The-Podsiadly

Copy link
Copy Markdown

Built off of @buildpeak's forked PR #41. Added parse_url method to mimic what werkzeug's did. This was copied from flask-restx's PR #463.

@bauerji bauerji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Please have a look at these comments, than I will try how it works in action

Comment thread flask_pydantic/openapi.py Outdated
Comment thread flask_pydantic/openapi.py
Comment thread flask_pydantic/openapi.py
Comment thread flask_pydantic/core.py Outdated
Comment thread HISTORY.md
Comment thread example_app/example.py
Comment thread flask_pydantic/version.py Outdated
@The-Podsiadly
The-Podsiadly force-pushed the feature/41/openapi-docs branch from 43c3cb9 to dfba9ee Compare August 14, 2022 20:34
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@The-Podsiadly
The-Podsiadly requested a review from bauerji August 14, 2022 20:41
@bauerji

bauerji commented Aug 28, 2022

Copy link
Copy Markdown
Collaborator

@The-Podsiadly Please, check the linter errors in the tests and modify the code accordingly.

Can you please add some tests for the openapi module? I don't like having such a piece of untested code in the code base.

@odie5533

Copy link
Copy Markdown

Any hope this might get integrated?

@otistamp

otistamp commented Mar 2, 2026

Copy link
Copy Markdown

bump

@stv8

stv8 commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@otistamp this PR appears to be quite out of date and needs some rework, I'm happy to review a new implementation

@otistamp

otistamp commented Mar 26, 2026

Copy link
Copy Markdown

i propose we close this pr and open a new one with a focus on documentation, typing and http data shapes first with optional validation. to me, that is the primary goal of this repo and it preserves the current functionality of the @validate decorator. i've forked this repo and opened a pull request with this concept implemented. would love to hear your thoughts @stv8 otistamp#2

@stv8

stv8 commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

@otistamp agree with this direction. I'll try to take a look this weekend, appreciate the movement on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants