Carousel for speakers #81

Fedois · 2026-01-30T11:42:01Z

added GSAP library to create an infinite carousel for the speakers section

netlify · 2026-01-30T11:42:06Z

✅ Deploy Preview for rubycon ready!

Name	Link
🔨 Latest commit	`5505cef`
🔍 Latest deploy log	https://app.netlify.com/projects/rubycon/deploys/697cc2cc27221f0008ab1e32
😎 Deploy Preview	https://deploy-preview-81--rubycon.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-01-30T11:42:10Z

🤖 Hi @Fedois, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

gemini-code-assist · 2026-01-30T11:42:15Z

Summary of Changes

Hello @Fedois, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user interface of the speakers section by introducing an interactive and visually appealing infinite carousel. By integrating the GSAP animation library, users can now smoothly browse speaker profiles with both automatic scrolling and manual drag functionality, improving engagement and content discoverability.

Highlights

GSAP Integration: The GreenSock Animation Platform (GSAP) and its Draggable plugin have been integrated into the project to enable advanced animation capabilities.
Infinite Speaker Carousel: The speakers section has been transformed into an infinite, auto-scrolling, and draggable carousel, enhancing the user experience for browsing speaker profiles.
New Speaker Entry: A new placeholder speaker, 'Julius Caesar', has been added to the speakers.yml data file, likely for testing the new carousel functionality.
Responsive Styling: New CSS rules have been added to style the carousel wrapper, track, and individual speaker cards, including responsive adjustments for smaller screens.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions

📋 Review Summary

This Pull Request introduces a new carousel feature for the speakers section using GSAP. The implementation involves changes to speaker data, HTML structure, CSS styling, and JavaScript for carousel functionality. The overall approach is clear, and the use of GSAP provides a dynamic user experience.

🔍 General Feedback

The integration of GSAP for the carousel is well-executed.
Consideration for responsive design with media queries in CSS is a good practice.
Minor improvements around data consistency, placeholder assets, and script organization would enhance the quality of the codebase.

github-actions · 2026-01-30T11:43:23Z

rubycon.it/_data/speakers.yml

+- avatar: '/assets/images/logo/0_0.jpeg'
+  full_name: Julius Caesar
+  role: Senior Ruby developer @Gallia 3P
+  #description: The crossing of the river Rubicon from the north by Julius Caesar was in early January 49 BC. The exact date is unknown. Scholars usually place it on the night of 10 and 11 January because of the speeds at which messengers could travel at that time. It is often asserted that Caesar's crossing of the river precipitated Caesar's civil war, but Caesar's forces had already crossed into Italy and occupied Ariminum (Rimini) the previous day.


🟢 There is a typo here: "cooming" should be "coming".

Suggested change

#description: The crossing of the river Rubicon from the north by Julius Caesar was in early January 49 BC. The exact date is unknown. Scholars usually place it on the night of 10 and 11 January because of the speeds at which messengers could travel at that time. It is often asserted that Caesar's crossing of the river precipitated Caesar's civil war, but Caesar's forces had already crossed into Italy and occupied Ariminum (Rimini) the previous day.

description: coming soon.

github-actions · 2026-01-30T11:43:26Z

rubycon.it/_data/speakers.yml

+  full_name: Julius Caesar
+  role: Senior Ruby developer @Gallia 3P
+  #description: The crossing of the river Rubicon from the north by Julius Caesar was in early January 49 BC. The exact date is unknown. Scholars usually place it on the night of 10 and 11 January because of the speeds at which messengers could travel at that time. It is often asserted that Caesar's crossing of the river precipitated Caesar's civil war, but Caesar's forces had already crossed into Italy and occupied Ariminum (Rimini) the previous day.
+  description: cooming soon.


🟡 The field keys is inconsistent with other speakers who use labels. It's recommended to maintain consistency across data entries.

Suggested change

description: cooming soon.

labels: [ruby, ruby on rails]

github-actions · 2026-01-30T11:43:30Z

rubycon.it/_includes/speakers.html

+            requestAnimationFrame(animate);
+        }
+
+        animate();


🟡 Duplicating HTML elements via innerHTML += track.innerHTML; can lead to accessibility and SEO concerns due to redundant content. Consider more robust methods for infinite carousels that dynamically manage clones or use libraries that handle this gracefully, if this becomes a problem in the future.

github-actions · 2026-01-30T11:43:32Z

rubycon.it/_includes/speakers.html

+            if (x <= -contentWidth) x += contentWidth;
+            if (x >= 0) x -= contentWidth;
+
+            gsap.set(track, { x });


🟡 It is generally good practice to separate JavaScript into external .js files for better organization, caching, and maintainability. Consider moving this script into a dedicated file.

github-actions · 2026-01-30T11:43:35Z

rubycon.it/_includes/speakers.html

@@ -1,33 +1,89 @@
 {% capture speakers_content %}
-<div class="grid sm:grid-cols-2 lg:grid-cols-3 gap-8">


🟢 The data-aos attributes for animations have been removed. If this was intentional due to the carousel implementation, it's fine. Otherwise, ensure this change aligns with the desired animation behavior for speakers.

github-actions · 2026-01-30T11:43:38Z

rubycon.it/_layouts/default.html

@@ -31,6 +31,8 @@

    {% include footer.html %}


🟢 While using CDNs for GSAP and Draggable.js is acceptable for static sites, for larger or more performance-critical applications, consider self-hosting these libraries or managing them via a package manager for better control over versioning and reliability, and for potential performance benefits.

gemini-code-assist

Code Review

This pull request introduces an infinite carousel for the speakers section using the GSAP library. The implementation is a good start, but there are a few critical and high-severity issues that need to be addressed. I've found a critical issue with mismatched versions of the GSAP library and its Draggable plugin, which could cause instability. There are also a couple of issues in the speaker data file: a typo and an incorrect key that will prevent labels from rendering for one of the speakers. Additionally, I've provided suggestions to improve the JavaScript implementation for better performance and maintainability, and a minor cleanup for the CSS. Please review the detailed comments.

rubycon.it/_layouts/default.html

rubycon.it/_data/speakers.yml

rubycon.it/_includes/speakers.html

gemini-code-assist · 2026-01-30T11:43:52Z

rubycon.it/_includes/speakers.html

+        gsap.registerPlugin(Draggable);
+
+        const track = document.querySelector('.speakers-track');
+        track.innerHTML += track.innerHTML;


Using innerHTML += innerHTML to duplicate content can be inefficient and has potential side effects, such as detaching event listeners from the original elements. A more performant and safer approach is to clone the existing nodes and append them.

[...track.children].forEach(child => track.appendChild(child.cloneNode(true)));

rubycon.it/assets/css/style.scss

Fedois added 3 commits January 30, 2026 12:14

merged main into carousel

90c5200

fix endfor in speakers.html

ebb3667

fixed css

6540712

github-actions bot reviewed Jan 30, 2026

View reviewed changes

gemini-code-assist bot reviewed Jan 30, 2026

View reviewed changes

Fedois added 2 commits January 30, 2026 12:52

fix version Dragable

01e81bb

fixed duplicate background-color in css

5505cef

Fedois assigned Fedois and emilianodellacasa and unassigned Fedois Jan 30, 2026

Repository owner deleted a comment from github-actions bot Jan 30, 2026

		@@ -1,33 +1,89 @@
		{% capture speakers_content %}
		<div class="grid sm:grid-cols-2 lg:grid-cols-3 gap-8">

Carousel for speakers #81

Are you sure you want to change the base?

Carousel for speakers #81

Conversation

Fedois commented Jan 30, 2026

Uh oh!

netlify bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rubycon ready!

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

📋 Review Summary

🔍 General Feedback

Uh oh!

github-actions bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Jan 30, 2026 •

edited

Loading