Repository navigation
feat: Connection::transaction_capable - #970
Merged
Merged
Conversation
`transaction_capable()` reads `SQL_TXN_CAPABLE` via `SQLGetInfo` and returns `odbc_sys::TransactionCapable`. Requires odbc-sys 0.31.3, which introduced the type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pacman82
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #960, as announced there: adds
Connection::transaction_capable(), which readsSQL_TXN_CAPABLEviaSQLGetInfoand returnsodbc_sys::TransactionCapabledirectly (pacman82/odbc-sys#112). The minimum odbc-sys version is raised to 0.31.3, the release that introduced the type.The integration test checks the expected value per database as a second test-case argument:
ALLfor Microsoft SQL Server, SQLite 3 and PostgreSQL,DDL_COMMITfor MariaDB.I ran the integration tests locally in the
test_linuxcontainer fromdocker-compose-ci.yml. All fourtransaction_capablecases pass. The only failures were two DuckDB tests: the image downloads thelinux-amd64DuckDB driver, which cannot load on my arm64 machine. That has nothing to do with this change.One note on the release PR #969: the 30.1.0 changelog entry takes its heading from the squashed commit of #960,
Connection::is_autocommit and Connection::transaction_capable. That commit only containsis_autocommit, so if 30.1.0 ships before this PR, the heading names a method the release does not have.🤖 Generated with Claude Code