Repository navigation
Publish PACIO badge verification - #3
Conversation
yuliumitre
commented
Aug 5, 2026
yuliumitre
commented
- Added badge verification page
- Published the first batch of badges
pkmitre
left a comment
pkmitre
left a comment
There was a problem hiding this comment.
Looks good, some minor thoughts noted in comments.
| "companyName": "Patient Centric Solutions", | ||
| "badgeCategory": "FHIR Implementer", | ||
| "eventName": "CMS Connectathon", | ||
| "eventDateRange": "2025-07-01", |
There was a problem hiding this comment.
eventDateRange value formats are not consistent, for example here the value is "2025-07-01" and other entries have things like "July 2026"
| <li class="nav-item"><a class="nav-link js-scroll-trigger" href="../index.html#about">About</a></li> | ||
| <li class="nav-item"><a class="nav-link js-scroll-trigger" href="../index.html#use_cases">Use Cases</a></li> | ||
| <li class="nav-item"><a class="nav-link js-scroll-trigger" href="../index.html#announcements">Announcements</a></li> | ||
| <li class="nav-item"><a class="nav-link js-scroll-trigger" href="../verification/">Badge Verification</a></li> |
There was a problem hiding this comment.
Adding this navigation link to the header has some of the navigation links in the header now break into two lines, which looks a bit awkward compared to the previous layout
Before
After
Maybe just the word "Badges" would help?
There was a problem hiding this comment.
Also, note in the second screenshot the "CLEAR FILTERS" button hangs out of its container (this is in Chrome).
| const badgeId = normalizeBadgeId(item.badgeId); | ||
| const itemEvent = normalizeBadgeId(item.eventId); | ||
| const itemCategory = normalizeBadgeId(item.badgeCategory); | ||
| const itemYear = normalizeBadgeId(recordYear(item)); |
There was a problem hiding this comment.
normalizeBadgeId seems to be used for a lot more than normalizing a badge ID, maybe a different name would be appropriate?
| DATE_PATTERN = re.compile(r"^\d{4}-\d{2}-\d{2}$") | ||
| EMAIL_PATTERN = re.compile(r"[\w.+-]+@[\w.-]+\.[A-Za-z]{2,}") | ||
| PROHIBITED_PUBLIC_FIELDS = { | ||
| "email", |
There was a problem hiding this comment.
In addition to prohibiting publishing an email field it could be beneficial to scan all text fields for things that look like emails or phone numbers. Might be more than is needed.
There was a problem hiding this comment.
We don't record phone numbers. Therefore, checking email should cover it.
| <div class="col-lg-10 mx-auto text-left"> | ||
| <p> | ||
| PACIO badges recognize participation and engagement in PACIO testing events. | ||
| A badge confirms that the listed recipient was issued the badge category for the listed event. |
There was a problem hiding this comment.
This sentence reads a bit awkward, maybe just "A badge confirms that the listed recipient participated in the listed event and category"
2 participants
