refactor: Replace picojpeg with jpegdec#2
Open
jpirnay wants to merge 1 commit intopablohc:feat/home-cover-settingsfrom
Open
refactor: Replace picojpeg with jpegdec#2jpirnay wants to merge 1 commit intopablohc:feat/home-cover-settingsfrom
jpirnay wants to merge 1 commit intopablohc:feat/home-cover-settingsfrom
Conversation
- Delete lib/picojpeg/ (picojpeg.c + picojpeg.h) - Rewrite JpegToBmpConverter to use JPEGDEC (callback-based decoder) instead of picojpeg; adds progressive JPEG support via patch_jpegdec.py - Preserve the deadline parameter introduced in this branch: store it in BmpConvertCtx and check it in the JPEGDEC draw callback (equivalent to the per-MCU-row check in the picojpeg version) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jpirnay
changed the title
pablohc
force-pushed
the
feat/home-cover-settings
branch
2 times, most recently
from
5fcc5ea to
f385cbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refactor-remove-picojpegrefactor.lib/picojpeg/(picojpeg.c + picojpeg.h, ~2200 lines)JpegToBmpConverterto use JPEGDEC's callback-based decoder instead of picojpegpatch_jpegdec.py, already present in this branch)deadlineparameter introduced in this branch: stored inBmpConvertCtxand checked inside the JPEGDEC draw callback — equivalent to the per-MCU-row check in the picojpeg versionAdditional Context
This is a mechanical port of
jpirnay/crosspoint-reader#refactor-remove-picojpegon top of this branch. The deadline behaviour is functionally identical to the picojpeg version; only the check site moves from an explicitfor (mcuY...)loop to the JPEGDEC draw callback.AI Usage
Did you use AI tools to help write this code? YES — Claude Code was used to apply the refactoring and adapt the deadline check to JPEGDEC's callback architecture.