You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was trying to improve the ListStructs inspector and found this :-
Lets say we have a struct abcd which has three fields initially. Now, we have a method call in our p4 program, methodA({0w10,0w1,0w2}) where methodA takes an argument of type abcd, but, our pruner removes all the fields of abcd because they are not accessed anywhere else. So, how do we tell ListStructs that this ListExpression tuple will be the initializerList for a particular struct. Inside IR::MethodCallExpression, there is a vector called typeArguments, but they currently seem to be empty. Maybe we will need to populate the typeMap?
Usually, you can tell the type of the structure by looking up the method declaration. So in this case, you would look up the declaration of methodA and check what the type of the parameter is. We can use the refmap and typeChecking for this if you want to. With the refMap and the typeMap you should be able to look up such declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues work from issue #5 , follows from PR #14.