perf: do not match each token in aggregation#474
Open
dkharms wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
==========================================
+ Coverage 70.44% 70.46% +0.02%
==========================================
Files 232 232
Lines 18371 18384 +13
==========================================
+ Hits 12942 12955 +13
+ Misses 4453 4452 -1
- Partials 976 977 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When getting tokens for aggregation, we scan each token and checking it against
*-- so basically, useless computations and IO (we have to load+unpack token blocks). I suggest to return range[firstTID; lastTID].Obviously, this optimization will have more impact on high-cardinality fields that span over several token blocks (like
remote_addror something).I will collect better measurements but for cold queries (flushed userspace cache and page cache) I got following results:
If you have used LLM/AI assistance please provide model name and full prompt: