Skip to content

fix: log search error if error code is present#468

Merged
cheb0 merged 2 commits into
mainfrom
0-log-search-error-for-error-code
Jul 20, 2026
Merged

fix: log search error if error code is present#468
cheb0 merged 2 commits into
mainfrom
0-log-search-error-for-error-code

Conversation

@cheb0

@cheb0 cheb0 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Description

Log search error if error code is present. Currently we do not log errors like SearchErrorCode_TOO_MANY_FRACTION_TOKENS and SearchErrorCode_MEMORY_LIMIT_EXCEEDED, but happily log parser errors in this log.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.42%. Comparing base (8d40146) to head (b813e95).

Files with missing lines Patch % Lines
storeapi/grpc_search.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   70.45%   70.42%   -0.04%     
==========================================
  Files         232      232              
  Lines       18364    18368       +4     
==========================================
- Hits        12939    12935       -4     
- Misses       4450     4458       +8     
  Partials      975      975              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Indexer-4 8d4014 2ae6a7
572462538.00 B/op 775659670.00 B/op 1.35 🔴

@eguguchkin eguguchkin added this to the v0.75.0 milestone Jul 20, 2026
@eguguchkin
eguguchkin requested a review from forshev July 20, 2026 09:58
@cheb0
cheb0 merged commit 2759e67 into main Jul 20, 2026
8 checks passed
@cheb0
cheb0 deleted the 0-log-search-error-for-error-code branch July 20, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants