Skip to content

fix: stop sw on context cancel (search err)#467

Merged
cheb0 merged 2 commits into
mainfrom
0-stop-sw-on-err
Jul 20, 2026
Merged

fix: stop sw on context cancel (search err)#467
cheb0 merged 2 commits into
mainfrom
0-stop-sw-on-err

Conversation

@cheb0

@cheb0 cheb0 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Description

Spot warning logs while debugging an issue - stopwatch not stopped on search error.

{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.539Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"warn","ts":"2026-07-13T18:22:26.540Z","message":"wrong Stopwatch usage: call getValues() w/o Stop()","name":"total"}
{"level":"error","ts":"2026-07-13T18:22:26.543Z","message":"search error","error":"search error: context canceled field: exception, query: 2","request":{"query":"...}}

  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter

codecov-commenter commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.47%. Comparing base (2759e67) to head (4c6a6e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   70.37%   70.47%   +0.09%     
==========================================
  Files         232      232              
  Lines       18368    18368              
==========================================
+ Hits        12926    12944      +18     
+ Misses       4463     4449      -14     
+ Partials      979      975       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Indexer-4 42fb1c 55f552
572784732.00 B/op 735154074.00 B/op 1.28 🔴

@eguguchkin eguguchkin added this to the v0.75.0 milestone Jul 20, 2026
@eguguchkin
eguguchkin requested a review from forshev July 20, 2026 09:59
@cheb0
cheb0 enabled auto-merge (squash) July 20, 2026 11:39
@cheb0
cheb0 merged commit 9225362 into main Jul 20, 2026
8 checks passed
@cheb0
cheb0 deleted the 0-stop-sw-on-err branch July 20, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants