Skip to content

fix: prevent unique stack traces explosion in mem profile#464

Merged
cheb0 merged 2 commits into
mainfrom
0-fix-exploded-alloc-stacks
Jul 21, 2026
Merged

fix: prevent unique stack traces explosion in mem profile#464
cheb0 merged 2 commits into
mainfrom
0-fix-exploded-alloc-stacks

Conversation

@cheb0

@cheb0 cheb0 commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Description

Currently, fixing it only for tree folding. It's harder to fix nodeOr since using a single call site reduces performance of OR queries. However, currently most allocs (LID block reads) happen when deep trees are created (we have eager LID cursors), so I assume the fix makes sense. nodeOr will be fixed with unrolled nodes and batched execution (partially).


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Indexer-4 42fb1c e9e0a4
572784732.00 B/op 769851024.00 B/op 1.34 🔴

@codecov-commenter

codecov-commenter commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.41%. Comparing base (1bcd504) to head (de49d73).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   70.42%   70.41%   -0.01%     
==========================================
  Files         232      232              
  Lines       18371    18371              
==========================================
- Hits        12937    12936       -1     
- Misses       4456     4458       +2     
+ Partials      978      977       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin added this to the v0.75.0 milestone Jul 20, 2026
@eguguchkin
eguguchkin requested a review from forshev July 20, 2026 09:59
@cheb0
cheb0 enabled auto-merge (squash) July 21, 2026 09:07
@cheb0
cheb0 merged commit 4ad8f17 into main Jul 21, 2026
8 checks passed
@cheb0
cheb0 deleted the 0-fix-exploded-alloc-stacks branch July 21, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants