Skip to content

perf: optimize TID entry lookup#454

Merged
cheb0 merged 1 commit into
mainfrom
0-optimize-tid-lookup-2
Jul 20, 2026
Merged

perf: optimize TID entry lookup#454
cheb0 merged 1 commit into
mainfrom
0-optimize-tid-lookup-2

Conversation

@cheb0

@cheb0 cheb0 commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Description

Redoing what was done previously, but more efficient. Mostly not possible to feel the difference except for aggregations with huge amount of bins in QPR.

Roughly _exists_:k8s_pod | by k8s_pod: ~460 ms => ~320 ms (hot query)


@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.45%. Comparing base (9225362) to head (319f4e0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
frac/sealed/token/table.go 57.14% 4 Missing and 2 partials ⚠️
frac/processor/aggregator.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   70.45%   70.45%   -0.01%     
==========================================
  Files         232      232              
  Lines       18368    18371       +3     
==========================================
+ Hits        12941    12943       +2     
  Misses       4451     4451              
- Partials      976      977       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin
eguguchkin requested a review from dkharms July 3, 2026 11:47

@dkharms dkharms left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eguguchkin eguguchkin added this to the v0.75.0 milestone Jul 13, 2026
@cheb0
cheb0 force-pushed the 0-optimize-tid-lookup-2 branch from 177ddbf to 319f4e0 Compare July 20, 2026 11:58
@cheb0
cheb0 enabled auto-merge (squash) July 20, 2026 11:58
@cheb0
cheb0 merged commit 1bcd504 into main Jul 20, 2026
8 checks passed
@cheb0
cheb0 deleted the 0-optimize-tid-lookup-2 branch July 20, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants