fix: add .compaction-plan to handle in-mid compaction crash#453
Conversation
6c52a39 to
bf68450
Compare
bf68450 to
c66f251
Compare
|
@seqbenchbot up main bulk |
|
@seqbenchbot down 8eedacf8 |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
2168c9a to
452dfe3
Compare
|
@seqbenchbot up main bulk |
|
@seqbenchbot down 1c283919 |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@seqbenchbot up main bulk |
eac5148 to
cc819bd
Compare
|
@seqbenchbot down 36d0de9f |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
cc819bd to
a056057
Compare
a056057 to
c8ce2fd
Compare
|
@seqbenchbot up main mixed |
|
@seqbenchbot down 29d571ac |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
2211456 to
7b74463
Compare
a41cef1 to
59284a4
Compare
59284a4 to
46ab336
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 70.48% 70.37% -0.11%
==========================================
Files 232 232
Lines 18269 18348 +79
==========================================
+ Hits 12876 12912 +36
- Misses 4432 4471 +39
- Partials 961 965 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ed4fcc0 to
439978c
Compare
439978c to
4d59887
Compare
Description
Compaction's substitute-and-delete of stale fractions isn't atomic, so a crash mid-compaction could leave source fractions behind and produce duplicates on restart.
This adds a
.compaction-planfile recording the participating fractions, which is written before merging and used on startup to clean up any leftover sources from an interrupted compaction.Closes #336
If you have used LLM/AI assistance please provide model name and full prompt: