Skip to content

fix: load_tiff in README was undefined#33

Open
culebron wants to merge 3 commits into
ozak:masterfrom
culebron:master
Open

fix: load_tiff in README was undefined#33
culebron wants to merge 3 commits into
ozak:masterfrom
culebron:master

Conversation

@culebron

@culebron culebron commented Mar 20, 2018

Copy link
Copy Markdown

fix for #31

@coveralls

coveralls commented Mar 20, 2018

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.09%) to 29.905% when pulling 7c81bf6 on culebron:master into e633a4e on ozak:master.

@ozak

ozak commented Mar 20, 2018

Copy link
Copy Markdown
Owner

It may be better to just add **kwargs instead of options=None and options= options, no?

@culebron

Copy link
Copy Markdown
Author

Yes, good idea.

Comment thread georasters/georasters.py
# Write the array
DataSet.GetRasterBand(band).WriteArray(Array)
DataSet.GetRasterBand(band).SetNoDataValue(ndv)
DataSet.GetRasterBand(band).SetNoDataValue(np.float64(ndv))

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't forcing a np.float64(ndv) force any dataset to become float, even the ones that are integers and so increasing file size?

@ozak

ozak commented Mar 21, 2018

Copy link
Copy Markdown
Owner

Doesn't forcing a np.float64(ndv) force any dataset to become float, even the ones that are integers and so increasing file size?

@culebron

Copy link
Copy Markdown
Author

@ozak I didn't test this. I found out that integer numpy matrices can't have None in them, and for integer ones (like ASTER DEM) it's only necessary to have a maksed array, without ndv.

It starts being confusing. Let me see how to run tests.

@ozak

ozak commented Mar 23, 2018

Copy link
Copy Markdown
Owner

To see the effect of this np.float I would save an integer raster with and without the option to see the difference in size.

I'm not sure I understood what you meant with the last comments... When is None being assigned to a numpy array?

@ozak

ozak commented Mar 23, 2018

Copy link
Copy Markdown
Owner

Also, how would you have a masked array without an ndv?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants