Skip to content

Conversation

@qdzlug
Copy link
Contributor

@qdzlug qdzlug commented May 8, 2025

This change adds in a number of changes to help customers more easily build images for the Oxide Rack.

Key Changes:

  • New documentation focusing on the Linux use case.
  • "imgbuild.sh" script and associated modules to provide a simple way to perform necessary tasks to get from iso -> image.
  • Modification of internet connectivity check from ping (which does not work under qemu's default networking) to a check of port 443 on oxide.computer.

@qdzlug qdzlug requested review from twinfees and wfchandler May 8, 2025 00:51
Copy link
Contributor

@wfchandler wfchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat that I haven't tested this, it looks good. I think we could replace build_app.sh with a simple cargo run, but don't feel strongly about it.


# Check if wimsy binary exists
WIMSY_BIN="./target/release/wimsy"
if [[ ! -x "$WIMSY_BIN" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use cargo run to execute the binary and build it if necessary, that would let us skip the build_app.sh script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to remember why I did that - there was a reason, but I have nfi what that is now. I'm going to merge this in and then revisit with my next round of changes (there are a few open PR's that I want to rebase onto this), and I'll just modify it then (once I figure out what I'm doing).

@qdzlug qdzlug merged commit bbd14f0 into oxidecomputer:main May 27, 2025
10 checks passed
@qdzlug qdzlug deleted the handhold branch May 27, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants