Skip to content

fix: isolate tsconfig caches across resolver clones - #1402

Open
sapphi-red wants to merge 1 commit into
mainfrom
fix/isolate-tsconfig-caches
Open

sapphi-red wants to merge 1 commit into
mainfrom
fix/isolate-tsconfig-caches

Conversation

@sapphi-red

Copy link
Copy Markdown
Member

Same with #916 but for tsconfig option.

The alternative is to extract the tsconfig related cache to a separate struct. I didn't use that approach because I thought that is rare and isn't worth the additional complexity.

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (bf29bf0) to head (b4fb973).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
+ Coverage   94.78%   94.80%   +0.02%     
==========================================
  Files          26       26              
  Lines        4828     4831       +3     
==========================================
+ Hits         4576     4580       +4     
+ Misses        252      251       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 1, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 5.28%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 19 untouched benchmarks
⏩ 5 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ pm/bun-flat 1.9 ms 2 ms -7.36%
❌ pm/npm-flat 1.9 ms 1.9 ms -3.15%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/isolate-tsconfig-caches (b4fb973) with main (bf29bf0)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants