Repository navigation
fix: isolate tsconfig caches across resolver clones - #1402
sapphi-red wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
+ Coverage 94.78% 94.80% +0.02%
==========================================
Files 26 26
Lines 4828 4831 +3
==========================================
+ Hits 4576 4580 +4
+ Misses 252 251 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 5.28%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | pm/bun-flat |
1.9 ms | 2 ms | -7.36% |
| ❌ | pm/npm-flat |
1.9 ms | 1.9 ms | -3.15% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix/isolate-tsconfig-caches (b4fb973) with main (bf29bf0)
Footnotes
-
5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Same with #916 but for
tsconfigoption.The alternative is to extract the tsconfig related cache to a separate struct. I didn't use that approach because I thought that is rare and isn't worth the additional complexity.